Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'expand links' link in UI doesn't work if one of the URLs is truncated with ellipsis #335

Open
kerchner opened this issue May 4, 2015 · 0 comments
Labels

Comments

@kerchner
Copy link
Member

kerchner commented May 4, 2015

This can sometimes occur in the case of a retweet. Clicking the "expand links" link for a tweet of this type in the /twitter-user/AccountXYZ page results in no action. Even when the tweet contains 2 or more URLs, and only one is truncated, the expand links link doesn't open.

This issue is related to #311, where the fetch_urls process is also not dealing with links that are truncated. As noted in #311 (as well as in associated PR #334) the tweet json in the case of a retweet should (usually?) contain the original, non-truncated URL(s). We should consider getting the URL from the ['retweeted_status']['urls'] node.

For an example, refer to the tweet json pasted in the comments of #334.

@kerchner kerchner added the bug label May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant