🐛 BUG: Unhandeled Promise Rejection in User tests.

[khase]

 User
    GET /api/users
      ✓ should return all users
      ✓ should fail with wrong authorization
    GET /api/users/roles
      ✓ should fail with wrong authorization
      ✓ should return an array with the defined roles
    PUT /api/users
(node:7360) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Can't set headers after they are sent.
(node:7360) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      ✓ should fail with bad request (admin privileges)
      ✓ should fail with bad request (email)
      ✓ should fail with wrong authorization (role edit)
      ✓ should fail with wrong authorization (uid)
      ✓ should update user data

[grosspersky]

Comes from this function:

  @Get('/')
  @Authorized(['teacher', 'admin'])
  getUsers(@CurrentUser() currentUser?: IUser) {
    return User.find({})
      .then((users) => {
        return users.map((user) => this.cleanUserObject(null, user, currentUser));
      });
  }

[felixbrucker]

@grosspersky this is not correct

It occurs because of these two functions: https://github.com/h-da/geli/blob/develop/api/src/controllers/UserController.ts#L40-L54

This happens because the route /users/roles also matches /users/:id

as a result both functions are called and the second one fails to set the headers because the response got already sent by the other function