Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] /give and /trade fail silently when the giver has nothing in their inventory that can be given/traded #29

Open
rivques opened this issue May 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rivques
Copy link
Collaborator

rivques commented May 31, 2024

No description provided.

@rivques rivques added the bug Something isn't working label May 31, 2024
@rivques rivques changed the title [BUG] /give fails silently when the giver has nothing in their inventory [BUG] /give and /trade fail silently when the giver has nothing in their inventory that can be given/traded May 31, 2024
@rivques
Copy link
Collaborator Author

rivques commented May 31, 2024

This occurs because Slack expects there to be something to put in the dropdown to select which item you want, and then gets mad when there isn't (e.g. if all your items are nontradeable, or in crafting/trades, or smth). This is exacerbated by #21 , because there's another reason to disqualify items from being able to be traded. However, this is likely a small issue in practice because onboarding should ensure everybody has some items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant