Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust call to pdb_selaltloc #117

Closed
mgiulini opened this issue Oct 13, 2022 · 3 comments · Fixed by #274
Closed

adjust call to pdb_selaltloc #117

mgiulini opened this issue Oct 13, 2022 · 3 comments · Fixed by #274
Assignees
Labels
bug Something isn't working pdb related to the pdb file to be used

Comments

@mgiulini
Copy link
Collaborator

mgiulini commented Oct 13, 2022

currently our pdb deals with alternate locations on the pdb with a call to select_by_occupancy

log.debug("Selecting residues with highest occupancy")
out_pdb_fname = Path(f"{inp_pdb_f.stem}-occ.pdb")
with open(inp_pdb_f, "r") as pdb_fh:
with open(out_pdb_fname, "w") as f:
for line in select_by_occupancy(pdb_fh):
f.write(line)

Unfortunately, this call always results in the residues with alternate locations being completely removed. I would rather select the residue with the highest occupancy. This was not a big problem when the call was performed after retrieving the file from pdb_renum, but removing that dependency (PR #118) can give rise to potential problems.

@mgiulini mgiulini self-assigned this Oct 21, 2022
@mgiulini mgiulini added bug Something isn't working pdb related to the pdb file to be used labels Oct 28, 2022
@mgiulini
Copy link
Collaborator Author

mgiulini commented Dec 5, 2022

unable to reproduce the issue, alternate locations seem to be correctly selected. I am closing this.

@mgiulini mgiulini closed this as completed Dec 5, 2022
@mgiulini
Copy link
Collaborator Author

mgiulini commented Dec 6, 2022

Re-opening this, as I was able to reproduce the issue: when all the entries of a residue show alternate locations, then the residue is completely removed from the pdb. I guess this should be handled at the pdbtools level

@mgiulini mgiulini reopened this Dec 6, 2022
@mgiulini
Copy link
Collaborator Author

haddocking/pdb-tools#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdb related to the pdb file to be used
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant