Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reacting with a category results in blank update #90

Closed
MoralCode opened this issue Oct 18, 2024 · 3 comments
Closed

Only reacting with a category results in blank update #90

MoralCode opened this issue Oct 18, 2024 · 3 comments

Comments

@MoralCode
Copy link
Contributor

MoralCode commented Oct 18, 2024

Scenario:

  1. User posts a message, but only says the bots name, and doesnt actually mention it (it still got picked up anyway i think - so tbh idk what is happening)
  2. editor (me) assumes the bot picked it up because the name was in there, and reacts with a category
  3. editor renders the post, seeing the report properly categorized in !status

Actual: the render contains a space for that update, but the contents of the update are blank (i.e. it only says " reports:" fllowed by an empty blockquote)

Expected: either the update is present or an error was raised sooner in the process about trying to categorize an unknown entry

@MoralCode
Copy link
Contributor Author

this may not be reproducible tbh.

@haecker-felix
Copy link
Owner

Hmm, it would be good to have exact steps how to reproduce this. Because by default this gets handled by the min_length setting.

Image

@MoralCode
Copy link
Contributor Author

Hmm, it would be good to have exact steps how to reproduce this. Because by default this gets handled by the min_length setting.

Image

my apologies, heres some clarifications that may help

  1. User posts a message containing an update long enough to count as an update, but doesnt actually mention the bot (only saying its name such that the bot does NOT pick up the update)
  2. an editor reacts with a category
  3. editor renders the post, seeing the report properly categorized in !status

Essentially this bug is about the entry somehow ending up empty in the final render because (in theory) the bot's first interaction with the post was when the editor categorized it (and NOT when it was first posted)

Does that help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants