Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor pre 1.0.0 release breaking changes #6

Open
nathanielc opened this issue Dec 6, 2018 · 2 comments
Open

Honor pre 1.0.0 release breaking changes #6

nathanielc opened this issue Dec 6, 2018 · 2 comments

Comments

@nathanielc
Copy link

According to semver the API may change with releases before the 1.0.0 release. https://semver.org/#spec-item-4

I would still like to track the breaking changes being made to the API using conventional commits so we can easily communicate to early adopters that the API did change.

The current behavior is to perform a major release version bump on all BREAKING CHANGES. I propose that for versions < 1.0.0 that BREAKING CHANGE commits only trigger a minor release.

@amowu
Copy link
Member

amowu commented Dec 12, 2018

Hi @nathanielc ! Thank you very much for your feedback.

The current behavior is to perform a major release version bump on all BREAKING CHANGES. I propose that for versions < 1.0.0 that BREAKING CHANGE commits only trigger a minor release.

If follow this rule, how do I change the version from < 1.0.0 to 1.0.0 ? always manually ?

@nathanielc
Copy link
Author

Yes,it would always be a manual process. that way the developers explicitly choose when to say that their API is now complete and will no longer break in future minor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants