Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to add element/slide attribute which includes equal signs #2038

Open
utensil opened this issue Nov 18, 2017 · 1 comment
Open

failed to add element/slide attribute which includes equal signs #2038

utensil opened this issue Nov 18, 2017 · 1 comment

Comments

@utensil
Copy link

utensil commented Nov 18, 2017

If the value of an attribute includes equal signs, then this attribute is ignored.

One example of the use case is setting data-background-iframe to a URL with a query string:

<!-- .slide: data-background-iframe="https://www.youtube.com/embed/XXXX?rel=0" data-background-interactive -->

The reason of this seems to be in https://github.com/hakimel/reveal.js/blob/master/plugin/markdown/markdown.js#L285 , which requires the value of an attribute doesn't include " or =.

@mrmanc
Copy link

mrmanc commented Dec 5, 2018

This prevents us from embedding published Google Drive documents as the URLs include = signs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants