Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We ought to test subsetted builds. #2282

Open
zvookin opened this issue Aug 19, 2017 · 2 comments
Open

We ought to test subsetted builds. #2282

zvookin opened this issue Aug 19, 2017 · 2 comments
Labels
build Issues related to building Halide and with CI

Comments

@zvookin
Copy link
Member

zvookin commented Aug 19, 2017

Some features, such as existence of a particular llvm backend, are optional and Halide purports to build and work even if they are not configured/available. This is not tested and tends to be rough when folks try to use subsetting. Not a huge priority, but we should consider adding test coverage for this.
@alexreinking alexreinking added the build Issues related to building Halide and with CI label Aug 7, 2020
@alexreinking
Copy link
Member

This is definitely still relevant, however low priority.

@alexreinking alexreinking changed the title We currently do not adequately test subsetted builds. We do not test subsetted builds. Sep 17, 2020
@alexreinking alexreinking changed the title We do not test subsetted builds. We ought to test subsetted builds. Sep 17, 2020
@alexreinking alexreinking reopened this Sep 17, 2020
@alexreinking alexreinking mentioned this issue Feb 16, 2021
Closed
@alexreinking
Copy link
Member

alexreinking commented Feb 16, 2021 •
edited
Loading

This has started biting us in practice. See #5744 and #5628.

A somewhat vacuous "solution" might be to drop support for subsetted builds and just require a full LLVM to compile.

@alexreinking alexreinking mentioned this issue Feb 16, 2021
Merged
@alexreinking alexreinking mentioned this issue Jul 8, 2024
Merged
@alexreinking alexreinking mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues related to building Halide and with CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexreinking @zvookin