Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGLCompute backend isn't being tested #5627

Open
steven-johnson opened this issue Jan 9, 2021 · 5 comments
Open

OpenGLCompute backend isn't being tested #5627

steven-johnson opened this issue Jan 9, 2021 · 5 comments
Milestone

Comments

@steven-johnson
Copy link
Contributor

In Issue #5475 we decided to remove OpenGL but keep OpenGLCompute; AFAICT, we don't do any testing at all on the OpenGLCompute backend. The only thing in our code that appears to explicitly test it is apps/openglcompute, which is Android-specific (and hasn't been built in ~years). If we intend to keep this backend, we need to add some level of testing for it on the buildbots.

@shoaibkamil
Copy link
Contributor

Agreed. Would it be simplest to turn this on for Linux testing? I realize those buildbots are pretty overtaxed, but I think testing for an additional backend isn't too bad (not like testing against an additional version of LLVM).

@steven-johnson
Copy link
Contributor Author

Agreed. I'll enable that today and see how badly broken we are (as I assume we must be if we haven't been testing).

@steven-johnson
Copy link
Contributor Author

Enabled it and I'm seeing LLVM errors of the form "Duplicate option categories" -- IIRC this is related to having multiple LLVM libraries in the open symbol space (i.e., one inside the driver, plus the one inside Halide)?

(This is on a Linux box with Nvidia hw + drivers)

@shoaibkamil
Copy link
Contributor

Yes, that does indeed seem like the same issue. I worked around it in Makefile builds by setting the environment variable WITH_LLVM_INSIDE_SHARED_LIBHALIDE= before building, but of course this is NOT a long-term solution and requires carefully setting LD_LIBRARY_PATHs.

@steven-johnson
Copy link
Contributor Author

See: #4651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants