-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenGLCompute backend isn't being tested #5627
Comments
Agreed. Would it be simplest to turn this on for Linux testing? I realize those buildbots are pretty overtaxed, but I think testing for an additional backend isn't too bad (not like testing against an additional version of LLVM). |
Agreed. I'll enable that today and see how badly broken we are (as I assume we must be if we haven't been testing). |
Enabled it and I'm seeing LLVM errors of the form (This is on a Linux box with Nvidia hw + drivers) |
Yes, that does indeed seem like the same issue. I worked around it in Makefile builds by setting the environment variable |
See: #4651 |
In Issue #5475 we decided to remove OpenGL but keep OpenGLCompute; AFAICT, we don't do any testing at all on the OpenGLCompute backend. The only thing in our code that appears to explicitly test it is
apps/openglcompute
, which is Android-specific (and hasn't been built in ~years). If we intend to keep this backend, we need to add some level of testing for it on the buildbots.The text was updated successfully, but these errors were encountered: