You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In CodeGen_LLVM, we call try_to_fold_vector_reduce<Call> on saturating_add or saturating_sub calls, while not providing information as to whether or not the accumulation is an addition or a subtraction:
This seems like incorrect behavior - I noticed this while restructuring CodeGen_X86 into separate optimization and code generation passes, because it appears that the accumulating saturating dot product instructions should trigger on both of these patterns:
In CodeGen_LLVM, we call
try_to_fold_vector_reduce<Call>
onsaturating_add
orsaturating_sub
calls, while not providing information as to whether or not the accumulation is an addition or a subtraction:https://github.com/halide/Halide/blob/11a049c3967a277173e288ffd802f08ce1a1b78e/src/CodeGen_LLVM.cpp#L2835-#L2839
This seems like incorrect behavior - I noticed this while restructuring CodeGen_X86 into separate optimization and code generation passes, because it appears that the accumulating saturating dot product instructions should trigger on both of these patterns:
The text was updated successfully, but these errors were encountered: