Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

初始化页面选择语言后，后续登录页没有保持所选语言 #6888

Closed
wan92hen opened this issue Oct 17, 2024 · 6 comments · Fixed by #6891
Closed

初始化页面选择语言后，后续登录页没有保持所选语言 #6888

wan92hen opened this issue Oct 17, 2024 · 6 comments · Fixed by #6891
Assignees
@guqing
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
2.20.x

Comments

@wan92hen
Copy link
Collaborator

系统信息

使用的哪种方式运行？

Docker

发生了什么？

初始化页面选择语言后，初始化完成后跳转到登录页没有保持所选语言。

复现步骤

No response

相关日志输出

No response

附加信息

No response
@guqing
Copy link
Member

guqing commented Oct 17, 2024

我试了没有复现，请看 VCR

Kapture.2024-10-17.at.16.40.48.mp4

/triage needs-information

@f2c-ci-robot f2c-ci-robot bot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Oct 17, 2024
@wan92hen
Copy link
Collaborator Author

我试了没有复现，请看 VCR

Kapture.2024-10-17.at.16.40.48.mp4
/triage needs-information

试下不用 localhost，用内网 IP 访问呢？

@ruibaby
Copy link
Member

ruibaby commented Oct 18, 2024

@wan92hen 是否使用了 1Panel 进行代理？我之前也复现过，似乎经过 1Panel 代理之后丢失了 Set-Cookie，导致没有把 language 放在 cookie 中，但是我测试加上 https 之后就可以了，暂不清楚为什么。

@guqing
Copy link
Member

guqing commented Oct 18, 2024 •
edited
Loading

@wan92hen 是否使用了 1Panel 进行代理？我之前也复现过，似乎经过 1Panel 代理之后丢失了 Set-Cookie，导致没有把 language 放在 cookie 中，但是我测试加上 https 之后就可以了，暂不清楚为什么。

原因是设置语言 Cookie 的时为 Cookie 添加了 Secure 属性，因此使用 ip 访问时不是 https 的会阻止 Cookie 设置，因此无法生效

@guqing
Copy link
Member

guqing commented Oct 18, 2024

/assign

@guqing
Copy link
Member

guqing commented Oct 18, 2024

/remove-triage needs-information
/kind bug
/milestone 2.20.x

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 18, 2024
@f2c-ci-robot f2c-ci-robot bot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Oct 18, 2024
@guqing guqing mentioned this issue Oct 18, 2024
Merged
@f2c-ci-robot f2c-ci-robot bot closed this as completed in 13644d2 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
2.20.x
Development

Successfully merging a pull request may close this issue.

fix: language preference is not remembered under non-HTTPS connections guqing/halo
3 participants
@ruibaby @wan92hen @guqing