Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.2.0 causes rspec version fallback #14

Closed
kevinansfield opened this issue Feb 8, 2013 · 5 comments
Closed

version 1.2.0 causes rspec version fallback #14

kevinansfield opened this issue Feb 8, 2013 · 5 comments
Assignees

Comments

@kevinansfield
Copy link

Just noticed that when running bundle update, the diff-lcs version changed from 1.1.3 -> 1.2.0 which then forced rspec version to fallback from 2.12.2 -> 2.0.1

@ghost ghost assigned halostatue Feb 8, 2013
@halostatue
Copy link
Owner

I'm not quite sure what you're seeing. @petergoldstein committed a change to rspec-expectations HEAD rspec/rspec-expectations@feba881 (see rspec/rspec-expectations#200) that adds compatibility with diff-lcs 1.2.

I ran bundle update and it still grabs 2.12.2 for me.

@kevinansfield
Copy link
Author

This is my Gemfile:

source 'https://rubygems.org'

gem 'rails', '3.2.11'

gem 'sqlite3'

gem 'jquery-rails'
gem 'ember-rails', github: 'emberjs/ember-rails'
gem 'bourbon'
gem 'devise'
gem 'haml-rails'
gem 'simple_form'

gem 'diff-lcs', '1.1.3' # hardcoded due to rspec downgrade issue with 1.2.0

group :assets do
  gem 'sass-rails'
  gem 'coffee-rails'

  gem 'uglifier'

  gem 'bootstrap-sass'
end

group :development do
  gem 'letter_opener'
  gem 'annotate'

  gem 'jazz_hands'

  gem 'better_errors'
  gem 'binding_of_caller'
end

group :test, :development do
  gem 'rspec-rails'
end

group :test do
  gem 'factory_girl_rails'
end

If I take out the gem 'diff-lcs', '1.1.3' line and run bundle update, version 1.2.0 is pulled in but all of the rspec gems are downgraded to 2.0.1 versions.

@kevinansfield
Copy link
Author

Also, if I remove the diff-lcs line and specify gem 'rspec', '~> 2.1' in my Gemfile, then diff-lcs is downgraded to version 1.1.3 by bundler.

@halostatue
Copy link
Owner

halostatue commented Feb 9, 2013

Unfortunately, as you can see with rspec/rspec-expectations#205 that I just opened, this is something that I can't fix in diff-lcs unless I were to release a 1.2 as 1.1.4 (and I'm not sure that's safe).

The problem boils down to the fact that 2.12.1 has a fixed version of ~> 1.1.3; the earliest version that satisfies a diff-lcs version of ~> 1.2 is version 2.0.1 (and that's mostly a good thing—the '>= 1.1.2' in 2.0.1 is dangerous, which is why I have put a similar suggested limitation in rspec/rspec-expectations#204).

I hope we will see this resolved by a point-release of rspec (at least rspec/rspec-expectations) soon.

@halostatue
Copy link
Owner

@kevinansfield there was a new release of rspec (2.13) today that should resolve this issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants