Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest version of wasm-bindgen fails to build with GH actions #3

Closed
hanyuone opened this issue Nov 11, 2024 · 0 comments · Fixed by #5
Closed

Newest version of wasm-bindgen fails to build with GH actions #3

hanyuone opened this issue Nov 11, 2024 · 0 comments · Fixed by #5
Assignees
Labels
bug Something isn't working

Comments

@hanyuone
Copy link
Owner

Relevant issues/PRs from external repositories:

It seems like the issue is something to do with the most recent Rust version update (1.82) which enables some flags from LLVM 19, and those instructions aren't supported from the (unmaintained) webassemblyjs.

From the Rust issue:

Yes Rust 1.82 would emit +reference-types in the target-features custom section of the output wasm (that section has always been there and it's just more features being added there). I believe that wasm-bindgen used that as an indication to automatically use other transforms that enables, for example, table.fill. That would be why wasm-bindgen first started "breaking" with Rust 1.82.

The current repository uses an older version of wasm-bindgen (0.2.93) to get around the bug, but the more permanent solution would be to wait until a new version of wasm-bindgen is released, which would include the relevant fixes.

@hanyuone hanyuone added the bug Something isn't working label Nov 11, 2024
@hanyuone hanyuone self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant