Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SD Variant of TOPP in planner #91

Closed
vonHartz opened this issue Jul 31, 2024 · 2 comments
Closed

Expose SD Variant of TOPP in planner #91

vonHartz opened this issue Jul 31, 2024 · 2 comments

Comments

@vonHartz
Copy link
Contributor

Could you expose the SD variant (desired duration) of TOPP in the planner, please?
I've written code for this here: ba883bc#diff-997402fdd7b22b417f2fd13fbddf8b0bd45afa374a6ca11c6d58aa426b8cc2f5

Happy to open a pull request if you're interested.

@Lexseal
Copy link
Collaborator

Lexseal commented Aug 1, 2024

thank you for contributing! certainly. I am not super familiar with time optimal parametrizer. what does the SD stand for? can you be more specific how I can help?

@vonHartz
Copy link
Contributor Author

vonHartz commented Aug 1, 2024

Thanks for the quick reply!

While TOPP-RA parametrizes the path to be time-optimal, ie as short as possible, the SD variant (meaning 'speficied duration'), allows the user to specify a desired duration for the path.
See: https://hungpham2511.github.io/toppra/python_api.html#toppra.algorithm.TOPPRAsd
It's also implemented in the TOPP-RA package. All I did, was adding a method for the MPLib planner that uses this variant.

I'll open a pull request and reference this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants