(feat) redis implementation for pub-sub, log streaming and canceller #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I'd maybe also add to the description what this change solves and why? |
marko-gacesa
changed the title
marko-gacesa
changed the title
marko-gacesa
force-pushed
the
redis-pubsub
branch
from
43ff22d to
b91d6c4
Compare
marko-gacesa
changed the title
marko-gacesa
force-pushed
the
redis-pubsub
branch
from
32bd578 to
4369d29
Compare
marko-gacesa
changed the title
eoinmcafee00
approved these changes
Aug 4, 2021
| @@ -166,6 +167,11 @@ type ( | |||
| EnableAnonymousAccess bool `envconfig:"DRONE_PROMETHEUS_ANONYMOUS_ACCESS" default:"false"` | |||
| } | |||
|
|
|||
| // Redis provides the redis configuration. | |||
| Redis struct { | |||
| ConnectionString string `envconfig:"DRONE_REDIS_CONNECTION"` | |||
There was a problem hiding this comment.
I recommend we also include redis username and database number as optional parameters. If someone is using hosted redis they may need to set these parameters https://github.com/go-redis/redis#quickstart
bot2-harness
pushed a commit
that referenced
this pull request
Dec 5, 2024
…nd fixed the pagination issue when filter if applied (#3108) * Made changes to the default value for sort * UI changes for search filter * UI changes for search filter * Search functionality changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces Redis as an optional dependency for Drone. If Redis connection string is defined, Drone will use Redis for pub-sub mechanism, log streaming and build canceller.
This PR is a part of HA push for Drone: To add support for several Drone servers to run in parallel.