add check on template extension type - throw error if invalid #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
suggested changes
Aug 31, 2021
eoinmcafee00
force-pushed
the
defect/template-name-extension
branch
from
15fa327 to
197c769
Compare
tphoney
reviewed
Aug 31, 2021
bot2-harness
pushed a commit
that referenced
this pull request
Dec 9, 2024
…3128) * fix: [AH-757]: do nothing if manifets manifest is already referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue has occurred where users have saved unsupported template file types.
Therefore I have added a check when a user uploads a template file, it has to be yaml, starlark or jsonnet.