Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a broken link in readme #3140

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix a broken link in readme #3140

merged 1 commit into from
Sep 13, 2021

Conversation

empire
Copy link

@empire empire commented Sep 12, 2021

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

  • Commit is a single logical unit of work, only use multiple commits if doing different tasks
  • Commit does not include commented out code or unneeded files
  • rebase of main branch

The Content

  • Must include testing for bug or feature
  • Must include appropriate documentation changes if it is introducing a new feature or changing existing functionality
  • Must pass existing test suites

The Commit Message

  • Short meaningful description (ex: remove deprecated steps)
  • Uses the imperative, present tense: "change", not "changed" or "changes"
  • Includes motivation for the change, and contrasts its implementation with the previous behavior

The Pull Request

  • What is the reason for this change
  • Example usage of the failure for a bug, or configuration and expected output for a feature
  • Steps to test the change

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link

@tphoney tphoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks

@tphoney tphoney merged commit 95a8495 into harness:master Sep 13, 2021
@empire empire deleted the patch-1 branch September 13, 2021 15:37
@d1wilko d1wilko added the bug label Sep 22, 2021
bot2-harness pushed a commit that referenced this pull request Dec 10, 2024
* feat: [CDE-549]: use --src-tls-verify
* feat: [CDE-549]: Handle no tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants