Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Starlark file size limit configurable #3291

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Make Starlark file size limit configurable #3291

merged 1 commit into from
Dec 6, 2022

Conversation

andrii-kasparevych
Copy link

This PR introduces a way to configure the Starlark generated YAML size limit as opposed to having a hard-coded value.
The default behavior does not change, but a user can set DRONE_STARLARK_SIZE_LIMIT env var on the drone server to allow for a larger file.
This would resolve an issue described here.

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

  • Commit is a single logical unit of work, only use multiple commits if doing different tasks
  • Commit does not include commented out code or unneeded files
  • rebase of main branch

The Content

  • Must include testing for bug or feature
  • Must include appropriate documentation changes if it is introducing a new feature or changing existing functionality
  • Must pass existing test suites

The Commit Message

  • Short meaningful description (ex: remove deprecated steps)
  • Uses the imperative, present tense: "change", not "changed" or "changes"
  • Includes motivation for the change, and contrasts its implementation with the previous behavior

The Pull Request

  • What is the reason for this change
  • Example usage of the failure for a bug, or configuration and expected output for a feature
  • Steps to test the change

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bradrydzewski
Copy link

Thanks @andrii-kasparevych for the pull request. @eoinmcafee00 could you please take a look? I did a quick glance and it looks good, but at this point you know the code better than I do :)

@eoinmcafee00 eoinmcafee00 merged commit 7a8c7e1 into harness:master Dec 6, 2022
@eoinmcafee00
Copy link

hi @andrii-kasparevych

Thanks again for the submission, it now has been merged.

@andrii-kasparevych andrii-kasparevych deleted the feature/starlark_file_size_limit_configurable branch December 14, 2022 15:20
bot2-harness pushed a commit that referenced this pull request Jan 21, 2025
* feat: [AH-883]: refetch webhook after update and fix route to webhook details page from webhook list page
* feat: [AH-883]: fix breaking css for inline inputs
* feat: [AH-883]: implement Edit flow with enterprise secret input
* feat: [AH-883]: Implement edit webhook page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants