Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dist files #1656

Closed
ghost opened this issue Nov 16, 2013 · 8 comments
Closed

add dist files #1656

ghost opened this issue Nov 16, 2013 · 8 comments

Comments

@ghost
Copy link

ghost commented Nov 16, 2013

Out of 20~ish projects installed through package management, and automated through grunt, chosen is the first who doesn't have dist files in the project source, why is that?
Since chosen is available through bower it seems like a good practise since people install it through a package manager 'for the web' and the project source right now is just there for contributors.

I tried to setup grunt-contrib-sass and parse it into css which resulted in the error below even though i have the compass gem installed.
Since i coulnd't get it to work i just end up manually downloading the package with the dist files.

'File to import not found or unreadable: compass/css3/box-sizing.'

So why aren't there any dist files/build map in the project source?

@stof
Copy link
Collaborator

stof commented Dec 2, 2013

We used to have the dist file in the git repo previously, but this was a pain in the ass as they were creating conflicts in all PRs as soon as another one was merged. Thus, half of the PRs were modifying the JS files directly instead of modifying the CoffeeScript source (requiring maintainers to ask them to redo the work)
This is why we decided not to include them in the git repo.

@greg0ire
Copy link

greg0ire commented Jan 2, 2014

Since bower downloads archives from github, wouldn't it be possible to use the "attach binary assets" functionality described here to make dist files available through bower without checking them in the repository ?

@stof
Copy link
Collaborator

stof commented Jan 2, 2014

This is the way we attach the build code to releases already

@greg0ire
Copy link

greg0ire commented Jan 2, 2014

@stof: Indeed, I can see that the zip corresponding to the green download button contains chosen.css, but it looks like bower uses another file :

bower chosen#~1.0.0 download https://github.com/harvesthq/chosen/archive/1.0.0.tar.gz

This file does not contain the css file.

How can I have bower grab the correct file ?

@stof
Copy link
Collaborator

stof commented Jan 2, 2014

this means that bower does not download the attach files but the archive containing the source code. You should contain that bower team to know whether bower supports build assets (and to request it if it does not). I have no idea as I'm not a bower user

@greg0ire
Copy link

greg0ire commented Jan 2, 2014

Ok, thanks. Looks like it is not possible yet but it is being worked on

@tjschuck
Copy link
Member

tjschuck commented Jan 2, 2014

Closing this one based on conversation above. Thanks @Mothproof, @greg0ire, and @stof.

@pfiller
Copy link
Contributor

pfiller commented Mar 28, 2015

bower install chosen

As of 1.4.2, Chosen supports bower installs. Read the 1.4.2 release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants