Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Client: Convert the test source set to a module #258

Closed
Tracked by #69
nathanklick opened this issue Aug 7, 2023 · 1 comment · Fixed by #300
Closed
Tracked by #69

Helm Client: Convert the test source set to a module #258

nathanklick opened this issue Aug 7, 2023 · 1 comment · Fixed by #300
Assignees
@jeromy-cannon
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. released
Milestone
v0.8.x

Comments

@nathanklick
Copy link
Member

nathanklick commented Aug 7, 2023 •
edited
Loading

Description

Due to the introduction of the Mockito framework and a limited amount of time/resources, the Helm Client unit tests were built as a classpath library instead of a Java module.

This source set should be refactored to be Java module; however, this is a very low priority issue.
@nathanklick nathanklick mentioned this issue Aug 7, 2023
Open
@github-project-automation github-project-automation bot moved this to 🆕 New in FST Suite Aug 7, 2023
@nathanklick nathanklick added P3 Low priority issue. Will not impact the release schedule if not complete. Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. labels Aug 7, 2023
@nathanklick nathanklick moved this from 🆕 New to 📋 Backlog in FST Suite Aug 7, 2023
@nathanklick nathanklick modified the milestones: v0.6.x, v0.7.x Aug 8, 2023
@jeromy-cannon jeromy-cannon moved this from 📋 Backlog to 🏗 In progress in FST Suite Aug 25, 2023
@nathanklick nathanklick modified the milestones: v0.7.x, v0.8.x Aug 25, 2023
@jeromy-cannon jeromy-cannon mentioned this issue Aug 30, 2023
Merged
@jeromy-cannon jeromy-cannon moved this from 🏗 In progress to 👀 In review in FST Suite Aug 30, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FST Suite Sep 5, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromy-cannon jeromy-cannon

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P3 Low priority issue. Will not impact the release schedule if not complete. released
Projects
FST Suite
Status: ✅ Done
Milestone
v0.8.x
Development

Successfully merging a pull request may close this issue.

feat: convert helm client test source set to a module hashgraph/full-stack-testing
3 participants
@jeromy-cannon @nathanklick @swirlds-automation