Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getTransactionByBlockHashAndIndex wrongfully returns maxPriorityFeePerGas and maxFeePerGas for legacy and 2930 transactions #1656

Closed
Tracked by #1475
konstantinabl opened this issue Aug 21, 2023 · 0 comments · Fixed by #1679
Closed
Tracked by #1475

eth_getTransactionByBlockHashAndIndex wrongfully returns maxPriorityFeePerGas and maxFeePerGas for legacy and 2930 transactions #1656

konstantinabl opened this issue Aug 21, 2023 · 0 comments · Fixed by #1679
Assignees
@konstantinabl
Labels
bug Something isn't working
Milestone
0.31.0

Comments

@konstantinabl
Copy link
Collaborator

konstantinabl commented Aug 21, 2023 •
edited
Loading

Description

While working on #1475 I found out that for legacy and 2930 transactions we return maxPriorityFeePerGas and maxFeePerGas fields populated with null, although those fields should only be returned when 1559 transactions is send.

N.B. Same issue happens in eth_getTransactionByBlockNumberAndIndex

Steps to reproduce

  1. Send legacy or 2930 transaction for eth_getTransactionByBlockHashAndIndex

Additional context

No response

Hedera network

other

Version

0.30.0

Operating system

None
@konstantinabl konstantinabl added the bug Something isn't working label Aug 21, 2023
@konstantinabl konstantinabl mentioned this issue Aug 21, 2023
Closed
@konstantinabl konstantinabl mentioned this issue Aug 25, 2023
Merged
2 tasks
@konstantinabl konstantinabl linked a pull request Aug 28, 2023 that will close this issue
Adds new types of transactions #1679
Merged
2 tasks
@Nana-EC Nana-EC added this to the 0.31.0 milestone Aug 28, 2023
@Nana-EC Nana-EC moved this to In Review in Smart Contract Sprint Board Aug 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konstantinabl konstantinabl

Labels
bug Something isn't working
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Adds new types of transactions hashgraph/hedera-json-rpc-relay
2 participants
@konstantinabl @Nana-EC