Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed unit test pipelines may be marked as successful #2320

Open
isavov opened this issue Apr 11, 2024 · 0 comments
Open

Failed unit test pipelines may be marked as successful #2320

isavov opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working limechain

Comments

@isavov
Copy link
Contributor

isavov commented Apr 11, 2024

Description

Because of an issue with istanbuljs/nyc it's possible that failed unit test runs are shown as passing in the CI, for example if a JavaScript heap out of memory error occurs.

Here's the issue that tracks the bug upstream istanbuljs/nyc#798
The current issue is related to #2300

Steps to reproduce

  1. Create an example test file
    echo "var x = []; while(true) x.push({ a:'123'.repeat(1000000) });" > test.ts
  2. run npx nyc ts-mocha --max-old-space-size=16 test.ts
  3. Check the exit code echo "Exit code: $?"

Expected exit code is 134, but the actual is 0

Additional context

No response

Hedera network

other

Version

v0.45.0

Operating system

None

@isavov isavov added bug Something isn't working limechain labels Apr 11, 2024
@isavov isavov self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain
Projects
Status: Backlog
Development

No branches or pull requests

1 participant