Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getLogs returns only 25 results #673

Closed
dimitrovmaksim opened this issue Nov 4, 2022 · 0 comments · Fixed by #701
Closed

eth_getLogs returns only 25 results #673

dimitrovmaksim opened this issue Nov 4, 2022 · 0 comments · Fixed by #701
Assignees
Labels
bug Something isn't working limechain
Milestone

Comments

@dimitrovmaksim
Copy link
Collaborator

dimitrovmaksim commented Nov 4, 2022

Description

Currently eth_getLogs returns only 25 results, because we are not setting a limit and it defaults to 25

To fix this we should check if there's a next query in the mirror node response and do those queries until we get all the logs. To limit the number of request we can also set the limit to 100, which is the current max for the mirror-node.
One problem with this solution is that in combination with this Issue #675 and filtering by block range (fromBlock -> toBlock) this could make getLogs very inefficient and slow

Steps to reproduce

Execute an eth_getLogs request for a block range that contains more than 25 logs

Additional context

No response

Hedera network

mainnet, testnet, previewnet

Version

all

Operating system

No response

@dimitrovmaksim dimitrovmaksim added the bug Something isn't working label Nov 4, 2022
@Nana-EC Nana-EC added this to the 0.12.0 milestone Nov 8, 2022
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Nov 8, 2022
@georgi-l95 georgi-l95 self-assigned this Nov 14, 2022
@Nana-EC Nana-EC modified the milestones: 0.12.0, 0.13.0 Nov 15, 2022
@Kalina-Todorova Kalina-Todorova moved this from Sprint BackLog to In Progress in Smart Contract Sprint Board Nov 15, 2022
@georgi-l95 georgi-l95 linked a pull request Nov 16, 2022 that will close this issue
2 tasks
Repository owner moved this from In Progress to Done in Smart Contract Sprint Board Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants