Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List all graph node env variables for hedera #700

Closed
mshakeg opened this issue Nov 16, 2022 · 5 comments · Fixed by #1744
Closed

List all graph node env variables for hedera #700

mshakeg opened this issue Nov 16, 2022 · 5 comments · Fixed by #1744
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mshakeg
Copy link
Contributor

mshakeg commented Nov 16, 2022

Problem

Hedera isn't supported by The Graph's hosted service, so developers looking to deploy their subgraphs will have to setup their own graph node. The subgraph-example doesn't list the graph node's env variables optimised for hedera. It would be helpful to anyone looking to set up a graph node to use that list of env variables instead of using their own guesses or the default values.

For example ETHEREUM_POLLING_INTERVAL defaults to 500ms, however looking at hashscan's blocks the block time seems to be about 2000ms and looking at hedera metrics the time to finality is ~5.45s so perhaps a more suitable ETHEREUM_POLLING_INTERVAL is between 6_000 - 10_000 ms.

Another example would be the GRAPH_ETHEREUM_BLOCK_INGESTOR_MAX_CONCURRENT_JSON_RPC_CALLS_FOR_TXN_RECEIPTS variable which defaults to 1_000, however, should probably be based on the relay service limits which in the case of Arkhia's Enterprise tier should be 200.

Solution

Alternatives

No response

@mshakeg mshakeg added the enhancement New feature or request label Nov 16, 2022
@Nana-EC Nana-EC added this to the 0.14.0 milestone Nov 24, 2022
@lukelee-sl lukelee-sl modified the milestones: 0.14.0, 0.15.0 Dec 21, 2022
@dimitrovmaksim
Copy link
Collaborator

This may take some time to figure out, probably after other issues are resolved and the whole thin is stable and can be tested extendedly.

@Kalina-Todorova Kalina-Todorova modified the milestones: 0.15.0, 0.16.0 Jan 4, 2023
@Kalina-Todorova Kalina-Todorova modified the milestones: 0.16.0, 0.17.0 Jan 17, 2023
@Nana-EC Nana-EC modified the milestones: 0.17.0, 0.18.0 Jan 30, 2023
@Kalina-Todorova Kalina-Todorova removed this from the 0.18.0 milestone Feb 15, 2023
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Apr 7, 2023
@Nana-EC Nana-EC added this to the 0.23.0 milestone Apr 7, 2023
@Nana-EC Nana-EC removed this from the 0.23.0 milestone Jun 9, 2023
@AlfredoG87
Copy link
Collaborator

even when in the docs says that this value defaults to 1000, i've seen is variable, and Hedera-Json-RPC-Relay does have a 1000 limit that in case it receives a higher block range it returns an error.

GRAPH_ETHEREUM_MAX_BLOCK_RANGE_SIZE=1000

@mshakeg
Copy link
Contributor Author

mshakeg commented Jul 28, 2023

@AlfredoG87 I recall going through the code a while back and it scales up/down based on failed calls, so GRAPH_ETHEREUM_MAX_BLOCK_RANGE_SIZE is just the MAX number of blocks it'll try to get concurrently, not sure what the limit is on hashio, but you'd want GRAPH_ETHEREUM_MAX_BLOCK_RANGE_SIZE to correspond with that limit or probably less since it's not a private dedicated relay.

@AlfredoG87
Copy link
Collaborator

Indeed the graph-node does scale up and down, but for the times it goes up, it fails.
yeah, the max on the relay is 1000, so this variable (GRAPH_ETHEREUM_MAX_BLOCK_RANGE_SIZE )should be 1000 or less.

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jul 31, 2023

@AlfredoG87 let's update https://github.com/hashgraph/hedera-json-rpc-relay/tree/main/tools/subgraph-example#prerequisites section with any custom graph env variables for optimized ingestion.

@Nana-EC Nana-EC added this to the 0.30.0 milestone Jul 31, 2023
@AlfredoG87 AlfredoG87 modified the milestones: 0.30.0, 0.31.0 Aug 21, 2023
@AlfredoG87 AlfredoG87 moved this from Sprint BackLog to In Progress in Smart Contract Sprint Board Sep 11, 2023
@AlfredoG87 AlfredoG87 moved this from In Progress to In Review in Smart Contract Sprint Board Sep 14, 2023
@AlfredoG87 AlfredoG87 moved this from In Review to In Progress in Smart Contract Sprint Board Sep 15, 2023
@AlfredoG87 AlfredoG87 removed this from the 0.31.0 milestone Sep 18, 2023
@AlfredoG87 AlfredoG87 added this to the 0.32.0 milestone Sep 18, 2023
@AlfredoG87 AlfredoG87 moved this from In Progress to In Review in Smart Contract Sprint Board Sep 18, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants