Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the BlockHeader.first_transaction_consensus_time lazily #17362

Closed
3 tasks done
Neeharika-Sompalli opened this issue Jan 13, 2025 · 0 comments · Fixed by #17442
Closed
3 tasks done

Set the BlockHeader.first_transaction_consensus_time lazily #17362

Neeharika-Sompalli opened this issue Jan 13, 2025 · 0 comments · Fixed by #17442
Assignees

Comments

@Neeharika-Sompalli
Copy link
Member

Neeharika-Sompalli commented Jan 13, 2025

Currently BlockHeader. first_transaction_consensus_time is set in startRound. It looks only at the uiser transactions in the Round and sets the field.

But that field should represent the first transaction in the block, which could be a preceding child transaction or TSS transaction or staking transaction.

Solution:

  • Set the field lazily after the first transaction that will be written to the block is decided

Testing:

  • Unit tests
  • Improve validator to see if this value is set on each block that has user transactions. Also validate if that is same timestamp as the first transaction inside the block
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Jan 13, 2025
@Neeharika-Sompalli Neeharika-Sompalli changed the title Set the BlockHeader. first_transaction_consensus_time lazily Set the BlockHeader.first_transaction_consensus_time lazily Jan 13, 2025
@netopyr netopyr moved this from 📋 Backlog to To Do in Services Team Jan 14, 2025
@tinker-michaelj tinker-michaelj self-assigned this Jan 19, 2025
@tinker-michaelj tinker-michaelj moved this from To Do to 👷🏼‍♀️ In Progress in Services Team Jan 19, 2025
@github-project-automation github-project-automation bot moved this from 👷🏼‍♀️ In Progress to ✅ Done in Services Team Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants