Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new singleton ENTITY_COUNTS and add a post upgrade step to update this state #17427

Open
3 tasks done
Tracked by #17316
Neeharika-Sompalli opened this issue Jan 17, 2025 · 0 comments · May be fixed by #17421
Open
3 tasks done
Tracked by #17316

Add a new singleton ENTITY_COUNTS and add a post upgrade step to update this state #17427

Neeharika-Sompalli opened this issue Jan 17, 2025 · 0 comments · May be fixed by #17421
Assignees
Milestone

Comments

@Neeharika-Sompalli
Copy link
Member

Neeharika-Sompalli commented Jan 17, 2025

  • Add a new singleton ENTITY_COUNTS state in EntityIdService that has a field (e.g. uint64 num_accounts or uint64 num_bytecodes) for each type of entity.
  • Add a 0.59-only step in SystemSetup.doPostUpgradeSetup() that initializes all these counts using direct calls to KVState.size() for every K/V state used by every service.
  • Update the WritableEntityIdStore API to "vend" entity id numbers by type, so that each time a service wants to create a new entity of a certain type, the EntityIdService can increment the correct ENTITY_COUNTS field.
@Neeharika-Sompalli Neeharika-Sompalli changed the title Add a new singleton ENTITY_COUNTS state in EntityIdService that has a field (e.g. uint64 num_accounts or uint64 num_bytecodes) for each type of entity. Add a new singleton ENTITY_COUNTS and add a post upgrade step to update this state Jan 17, 2025
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Jan 17, 2025
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.59 milestone Jan 17, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Jan 17, 2025
@Neeharika-Sompalli Neeharika-Sompalli moved this from 📋 Backlog to 👀 In Review in Services Team Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging a pull request may close this issue.

1 participant