chore: contract resources for tests can't be compiled in-situ because of dependences on system contract headers #17432
Labels
Good First Issue
Either a small change or a medium change concentrated in a single component.
Hedera Smart Contract Service
Issues related to the Hedera Smart Contract Service.
Background
Some (many?) of the contracts used for tests (find them in
hedera-node/test-clients/src/main/resources/contract/contracts
) can't be compiled where they sit because they refer to imports - interfaces or abstract contracts - for system contracts or common types. (E.g.,IHederaTokenService.sol
orHederaResponseCodes.sol
.)There has been some attempt to deal with this by duplicating those dependencies into the various contract directories but that's a bad idea for obvious reasons.
These imported dependencies should each live in one place in the
test-clients/main/resources/...
tree (not necessarily the same place, though it could be). And the instructions athow-to-compile-contracts.txt
should be updated to have the proper--include-path
argument(s) so that these contracts can reliably be compiled in place. (In fact,how-to-compile-contracts.txt
should be changed to be a shell script.)Acceptance Criteria
how-to-compile-contracts.txt
, andtest-clients/src/main/resources
treeDependencies
No response
Definition of Ready (DoR) Checklist
Definition of Done (DoD) Checklist
The text was updated successfully, but these errors were encountered: