feat: Use Transaction.body by default, normalize other transactions on ingest #17449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17449 +/- ##
=========================================
Coverage 68.91% 68.91%
- Complexity 22667 22673 +6
=========================================
Files 2613 2613
Lines 97892 97900 +8
Branches 10156 10156
=========================================
+ Hits 67463 67471 +8
Misses 26613 26613
Partials 3816 3816
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR simplifies the usage of
Transaction. The fieldTransaction.bodyis used by default to store theTransactionBody. If a transaction is submitted to the network that does not follow the new standard, it is adjusted on ingest.Related issue(s):
Fixes #17448
Notes for reviewer:
Checklist