Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: enable compaction during reconnects #17129

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

OlegMazurov
Copy link
Contributor

@OlegMazurov OlegMazurov commented Dec 18, 2024

Description:
Enable compaction for the learner's data source copy.

Related issue(s):

Fixes #17065

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@OlegMazurov OlegMazurov added the Performance Issues related to performance concerns. label Dec 18, 2024
@OlegMazurov OlegMazurov added this to the v0.58 milestone Dec 18, 2024
@OlegMazurov OlegMazurov self-assigned this Dec 18, 2024
@OlegMazurov OlegMazurov requested review from a team as code owners December 18, 2024 22:39
Copy link

codacy-production bot commented Dec 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1128c74) 95476 64916 67.99%
Head commit (51997f3) 95665 (+189) 65070 (+154) 68.02% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17129) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (1128c74) to head (51997f3).
Report is 15 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #17129      +/-   ##
=============================================
+ Coverage      64.25%   64.26%   +0.01%     
- Complexity     20819    20882      +63     
=============================================
  Files           2547     2549       +2     
  Lines          95713    95985     +272     
  Branches       10014    10044      +30     
=============================================
+ Hits           61498    61683     +185     
- Misses         30606    30673      +67     
- Partials        3609     3629      +20     
Files with missing lines Coverage Δ
...b/src/main/java/com/swirlds/merkledb/MerkleDb.java 75.00% <100.00%> (ø)
...ds/virtualmap/internal/merkle/VirtualRootNode.java 57.53% <ø> (-0.14%) ⬇️

... and 94 files with indirect coverage changes

Impacted file tree graph

artemananiev
artemananiev previously approved these changes Dec 20, 2024
@OlegMazurov OlegMazurov merged commit aee0358 into develop Dec 20, 2024
45 checks passed
@OlegMazurov OlegMazurov deleted the 17065-D-compaction-during-reconnect branch December 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issues related to performance concerns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled compaction during reconnect leads to a large number of files/descriptors
3 participants