Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate h5ai-nginx patch consistently #101

Closed
acuarica opened this issue Dec 12, 2023 · 0 comments · Fixed by #164
Closed

Generate h5ai-nginx patch consistently #101

acuarica opened this issue Dec 12, 2023 · 0 comments · Fixed by #164
Assignees
@acuarica

Comments

@acuarica
Copy link
Contributor

We currently use IntelliJ to generate the h5ai-nginx, but it seems it can reorder previously applied changes when introducing a small change. #100 (comment)

We should generate the patch in a way that does not reorder changes. We may use git add . && git diff --staged to generate the patch. Moreover, this way it is reproducible and we can automate it if needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acuarica acuarica

Labels
None yet
Projects
Smart Contract Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use upstream Sourcify images hashgraph/hedera-sourcify
1 participant
@acuarica