Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CI unit tests for contract-call-decoder #94

Closed
acuarica opened this issue Dec 8, 2023 · 2 comments · Fixed by #108
Closed

Enable CI unit tests for contract-call-decoder #94

acuarica opened this issue Dec 8, 2023 · 2 comments · Fixed by #108
Assignees
@acuarica
Milestone
0.2.0

Comments

@acuarica
Copy link
Contributor

acuarica commented Dec 8, 2023

The unit tests for contract-call-decoder, cd packages/contract-call-decoder && npm run test, fail on CI because of an external IPFS request timeout.

Enable those tests in CI by avoiding the external IPFS request.
@Nana-EC
Copy link
Collaborator

Nana-EC commented Dec 13, 2023

If possible maybe we can point it to a local IPFS node spun up as part of CI

@Nana-EC Nana-EC added this to the 0.2.0 milestone Dec 13, 2023
@Nana-EC Nana-EC moved this to Sprint BackLog in Smart Contract Sprint Board Dec 13, 2023
@acuarica
Copy link
Contributor Author

@Nana-EC I've checked the Sourcify repo and they've skipped the problematic test as well ethereum/sourcify@cba1738.

We could take the same approach and skip the test to enable CI testing, and figure out later how to fix the test.

@acuarica acuarica linked a pull request Dec 15, 2023 that will close this issue
ci: enable contract-call-decoder unit tests in CI by skipping IPFS test #108
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Sprint BackLog to Done in Smart Contract Sprint Board Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acuarica acuarica

Labels
None yet
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

ci: enable contract-call-decoder unit tests in CI by skipping IPFS test hashgraph/hedera-sourcify
2 participants
@acuarica @Nana-EC