feat: separate explorer from mirror node install/uninstall #1177
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
E2E Test Report 17 files ±0 126 suites ±0 1h 28m 28s ⏱️ + 2m 34s Results for commit b0e139f. ± Comparison against base commit 473a650. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 82.69% 83.02% +0.33%
==========================================
Files 77 78 +1
Lines 21424 21730 +306
Branches 1515 1833 +318
==========================================
+ Hits 17717 18042 +325
+ Misses 3641 3573 -68
- Partials 66 115 +49
... and 36 files with indirect coverage changes |
jeromy-cannon
added
the
PR: Needs Approval
| // Install ingress controller only if it's not already present | ||
| if (!(await this.k8.isIngressControllerInstalled())) { | ||
| valuesArg += ' --set ingress.enabled=true'; | ||
| valuesArg += ' --set haproxyIngressController.enabled=true'; | ||
| valuesArg += ` --set ingressClassName=${namespace}-hedera-explorer-ingress-class`; | ||
| valuesArg += ` --set-json 'ingress.hosts[0]={"host":"${hederaExplorerTlsHostName}","paths":[{"path":"/","pathType":"Prefix"}]}'`; | ||
| } |
There was a problem hiding this comment.
FYI, @JeffreyDallas, in #929 we will need this logic when the new --enable-ingress is set to true.
There was a problem hiding this comment.
These line are moved to explorer command, why still need it in mirror command?
I assume this is how it work after implementing enable ingress flag/feature:
1 . deploy mirror
2. deploy explorer with enable ingress set to true
solo cluster will be updated with new valueArges showing in above 4 lines , ingress controller will be installed
then explorer chart will be installed
jeromy-cannon
added
PR: Merge Conflicts
…explorer Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/mirror_node.ts
Description
This pull request changes the following:
namespaceparameterRelated Issues