feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

instamenta · 2025-01-14T14:28:40Z

Description

if the Hedera platform version satisfied 0.59.x or is greater set the internal IP address to 127.0.0.1 in config.txt
else use the existing logic

Related Issues

Closes #1150

github-actions · 2025-01-14T14:30:27Z

Unit Test Results - Linux

1 files ±0 59 suites ±0 3s ⏱️ ±0s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit e2078e6. ± Comparison against base commit af3ae29.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-14T14:32:22Z

Unit Test Results - Windows

1 files ±0 59 suites ±0 14s ⏱️ ±0s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit e2078e6. ± Comparison against base commit af3ae29.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-14T15:16:25Z

E2E Test Report

17 files 126 suites 1h 27m 55s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs 269 ✅ 0 💤 0 ❌

Results for commit e2078e6.

♻️ This comment has been updated with latest results.

codacy-production · 2025-01-14T15:16:42Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -1.00%)	✅ 87.80%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`af3ae29`)	21354	17866	83.67%
Head commit (`e2078e6`)	21408 (+54)	17914 (+48)	83.68% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1162)	41	36	87.80%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

codecov · 2025-01-14T15:17:56Z

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (af3ae29) to head (e2078e6).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/profile_manager.ts	84.84%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   82.88%   82.87%   -0.02%     
==========================================
  Files          77       77              
  Lines       21381    21408      +27     
  Branches     1805     1489     -316     
==========================================
+ Hits        17721    17741      +20     
- Misses       3525     3585      +60     
+ Partials      135       82      -53

Files with missing lines	Coverage Δ
src/commands/flags.ts	`75.45% <100.00%> (+0.03%)`	⬆️
version.ts	`100.00% <100.00%> (ø)`
src/core/profile_manager.ts	`96.32% <84.84%> (-0.80%)`	⬇️

... and 28 files with indirect coverage changes

Signed-off-by: instamenta <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…the nodes during node setup Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…on from the remainder of solo Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Alex Kuzmin <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…to push the changes through application.env anymore Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

## [0.34.0](v0.33.0...v0.34.0) (2025-01-24) ### Features * `solo deployment create` should use the context and cluster provided for where to save the remote config ([#1142](#1142)) ([fe42edd](fe42edd)) * Connect to multicluster deployments and validate remoteConfigs ([#1141](#1141)) ([c78e226](c78e226)) * for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt ([#1162](#1162)) ([4ca488b](4ca488b)) * node upgrade command and new e2e tests ([#1133](#1133)) ([1cf5893](1cf5893)) * separate explorer from mirror node install/uninstall ([#1177](#1177)) ([0887fa6](0887fa6)) * solo network destroy should update remote-config ([#1155](#1155)) ([98b028f](98b028f)) * Update solo to load remote config near entry point ([#1176](#1176)) ([473a650](473a650)) ### Bug Fixes * merge error due to change of remote_config_tasks ([#1197](#1197)) ([9d1a8cb](9d1a8cb)) * Normalize mirror node resources path ([#1175](#1175)) ([ab018a7](ab018a7)) * Refactor RemoteConfigTasks class ([#1185](#1185)) ([66cfc4d](66cfc4d)) * remove k8.getKubeConfig ([#1182](#1182)) ([89c557a](89c557a)) * Set mirror node importer startDate ([#1174](#1174)) ([9d9ef53](9d9ef53)) * update hedera explorer chart version and location ([#1188](#1188)) ([0c415ef](0c415ef)) * use "double fork" to invoke port forward within Taskfile ([#1148](#1148)) ([d662d3f](d662d3f))

swirlds-automation · 2025-01-24T15:40:59Z

🎉 This PR is included in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

instamenta requested a review from jeromy-cannon January 14, 2025 14:28

instamenta self-assigned this Jan 14, 2025

instamenta requested review from leninmehedy and a team as code owners January 14, 2025 14:28

instamenta linked an issue Jan 14, 2025 that may be closed by this pull request

for v0.59.x we need to set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1150

Closed

instamenta requested a review from a team as a code owner January 14, 2025 16:00

jeromy-cannon added Audit Issues resulting from a code or process audit PR: Checks Failed A pull request where the checks have failed. and removed Audit Issues resulting from a code or process audit labels Jan 15, 2025

jeromy-cannon requested review from a team as code owners January 17, 2025 18:38

jeromy-cannon requested a review from rbarkerSL January 17, 2025 18:38

instamenta and others added 13 commits January 17, 2025 22:51

implemented

a2cfe3e

Signed-off-by: instamenta <[email protected]>

change hedera platform version

d8c1b49

Signed-off-by: instamenta <[email protected]>

networkAdmin.exportCandidateRoster=true

0161b92

Signed-off-by: Jeromy Cannon <[email protected]>

update the application.env with the consensus node id and push it to …

4b0d474

…the nodes during node setup Signed-off-by: Jeromy Cannon <[email protected]>

bump solo-charts to v0.42.9

b3de239

Signed-off-by: Jeromy Cannon <[email protected]>

fixed unit tests

821f6db

Signed-off-by: Jeromy Cannon <[email protected]>

update version used for a couple of e2e test to use a different versi…

6f88246

…on from the remainder of solo Signed-off-by: Jeromy Cannon <[email protected]>

Latitude: Experiment with 0.42.9, Roster props

a8823ef

Signed-off-by: Alex Kuzmin <[email protected]>

addressBook.useRosterLifecycle=true

de5470f

Signed-off-by: Alex Kuzmin <[email protected]>

set env variable outside of command instead of as prefix

acc0750

Signed-off-by: Jeromy Cannon <[email protected]>

fixed bug for when setting env variable before calling taskfile

f7faa71

Signed-off-by: Jeromy Cannon <[email protected]>

bump solo charts to 0.42.10

3fedd77

Signed-off-by: Jeromy Cannon <[email protected]>

updated container to use passed in values correctly so we don't need …

0ac7699

…to push the changes through application.env anymore Signed-off-by: Jeromy Cannon <[email protected]>

updated version for local tests to use v0.58.3

e2078e6

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 01150-for-v059x-we-need-to-set-the-internal-ip-address-to-127001-to-avoid-an-iss-in-configtxt branch from 6cf34ff to e2078e6 Compare January 17, 2025 22:54

jeromy-cannon approved these changes Jan 17, 2025

View reviewed changes

jeromy-cannon removed the PR: Checks Failed A pull request where the checks have failed. label Jan 17, 2025

jeromy-cannon merged commit 4ca488b into main Jan 18, 2025
42 of 43 checks passed

jeromy-cannon deleted the 01150-for-v059x-we-need-to-set-the-internal-ip-address-to-127001-to-avoid-an-iss-in-configtxt branch January 18, 2025 08:17

jeromy-cannon restored the 01150-for-v059x-we-need-to-set-the-internal-ip-address-to-127001-to-avoid-an-iss-in-configtxt branch January 18, 2025 08:18

jeromy-cannon deleted the 01150-for-v059x-we-need-to-set-the-internal-ip-address-to-127001-to-avoid-an-iss-in-configtxt branch January 21, 2025 12:44

swirlds-automation added the released label Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

instamenta commented Jan 14, 2025

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codacy-production bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

swirlds-automation commented Jan 24, 2025

feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

Conversation

instamenta commented Jan 14, 2025

Description

Related Issues

github-actions bot commented Jan 14, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 14, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 14, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Jan 14, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

swirlds-automation commented Jan 24, 2025

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

codacy-production bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading