New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make K8.getKubeConfig() private #1179

Closed

Tracked by

jeromy-cannon opened this issue Jan 17, 2025 · 1 comment · Fixed by #1182

Closed

Tracked by

make K8.getKubeConfig() private #1179

jeromy-cannon opened this issue Jan 17, 2025 · 1 comment · Fixed by #1182

Assignees

Labels

Contributor

jeromy-cannon commented Jan 17, 2025 •

edited

Loading

The K8.getKubeConfig() method violates the Law of Demeter.

create a k8.getCurrentContext()
create a k8.getCurrentClusterName()
make k8.getKubeConfig() private
update places using k8.getKubeConfig() to leverage the two new methods

jeromy-cannon mentioned this issue

Solo: Code Quality #50

Open

jeromy-cannon assigned Ivo-Yankov

jeromy-cannon added the P1 label

Ivo-Yankov mentioned this issue

fix: remove k8.getKubeConfig #1182

Merged

jeromy-cannon closed this as completed in #1182

Contributor

swirlds-automation commented Jan 24, 2025

🎉 This issue has been resolved in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment