fix: do checksum check after downloading platform zip file #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leninmehedy
changed the title
leninmehedy
requested review from
jeromy-cannon
and removed request for
tomzhenghedera
leninmehedy
force-pushed
the
000111-do-checksum-check
branch
from
442bfa5 to
a5824b7
Compare
E2E Test Results735 tests +1 735 ✅ +1 13m 9s ⏱️ + 1m 10s Results for commit 6cda7e1. ± Comparison against base commit 8fd976b. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 63.73% 63.76% +0.02%
==========================================
Files 27 27
Lines 2570 2558 -12
Branches 422 373 -49
==========================================
- Hits 1638 1631 -7
+ Misses 932 927 -5
|
… in the container Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
000111-do-checksum-check
branch
from
4a2cd69 to
6cda7e1
Compare
jeromy-cannon
approved these changes
Mar 5, 2024
swirlds-automation
added a commit
that referenced
this pull request
Mar 8, 2024
## [0.22.0](v0.21.2...v0.22.0) (2024-03-08) ### Features * **cli:** allow user to set jvm options for Hedera nodes ([#84](#84)) ([22ff35d](22ff35d)) * download helm binary based on os and platform architecture ([#128](#128)) ([e64e9a2](e64e9a2)) ### Bug Fixes * do checksum check after downloading platform zip file ([#125](#125)) ([3d91617](3d91617)) * updated incorrect log messages ([#132](#132)) ([d890974](d890974)) ### Performance Improvements * enhance account key update logic to batch transactions instead of loading all with sleep ([#105](#105)) ([e4bd1ef](e4bd1ef))
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we made changes to pull platform zip file directly inside the container. This PR introduces the required checksum check and it runs in parallel for all nodes, which reduces overall execution time.
This pull request changes the following:
Related Issues