Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated incorrect log messages #132

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • Update incorrect log messages for destroy network and stop nodes

Related Issues

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon self-assigned this Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Unit Test Results

 1 files  ±0  13 suites  ±0   20s ⏱️ ±0s
83 tests ±0  83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5d6575a. ± Comparison against base commit e4bd1ef.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

E2E Test Results

736 tests  ±0   736 ✅ ±0   12m 9s ⏱️ -11s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5d6575a. ± Comparison against base commit e4bd1ef.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e4bd1ef) 2220 1447 65.18%
Head commit (5d6575a) 2220 (+0) 1447 (+0) 65.18% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#132) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.76%. Comparing base (e4bd1ef) to head (5d6575a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          27       27           
  Lines        2634     2634           
  Branches      432      432           
=======================================
  Hits         1706     1706           
  Misses        928      928           
Files Coverage Δ
src/commands/network.mjs 0.00% <0.00%> (ø)
src/commands/node.mjs 56.25% <0.00%> (ø)

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review March 6, 2024 19:24
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners March 6, 2024 19:24
@jeromy-cannon jeromy-cannon merged commit d890974 into main Mar 6, 2024
18 of 19 checks passed
@jeromy-cannon jeromy-cannon deleted the 00131-fix-log-messages branch March 6, 2024 20:26
swirlds-automation added a commit that referenced this pull request Mar 8, 2024
## [0.22.0](v0.21.2...v0.22.0) (2024-03-08)

### Features

* **cli:** allow user to set jvm options for Hedera nodes ([#84](#84)) ([22ff35d](22ff35d))
* download helm binary based on os and platform architecture ([#128](#128)) ([e64e9a2](e64e9a2))

### Bug Fixes

* do checksum check after downloading platform zip file ([#125](#125)) ([3d91617](3d91617))
* updated incorrect log messages ([#132](#132)) ([d890974](d890974))

### Performance Improvements

* enhance account key update logic to batch transactions instead of loading all with sleep ([#105](#105)) ([e4bd1ef](e4bd1ef))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update incorrect log messages for destroy network and stop nodes
3 participants