Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase load balancer check waiting time and make values configurable via env #1461

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Increases default max attempts from 30 to 60 for the load balancer availability check
  • Increases default check delay from 2s to 5s for the load balancer availability check
  • Makes both the check delay and max attempts configurable via environment variables

Related Issues

@nathanklick nathanklick requested review from leninmehedy and a team as code owners February 24, 2025 00:56
@nathanklick nathanklick self-assigned this Feb 24, 2025
@nathanklick nathanklick added Bug A error that causes the feature to behave differently than what was expected based on design docs P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Feb 24, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b1440a21 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b1440a2) Report Missing Report Missing Report Missing
Head commit (71b38d0) 25706 21831 84.93%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1461) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nathanklick nathanklick merged commit 9e7e572 into release/0.35 Feb 24, 2025
43 of 50 checks passed
@nathanklick nathanklick deleted the 01460-r53-lb-check-timeout branch February 24, 2025 01:37
swirlds-automation added a commit that referenced this pull request Feb 24, 2025
## [0.35.1](v0.35.0...v0.35.1) (2025-02-24)

### Bug Fixes

* increase load balancer check waiting time and make values configurable via env ([#1461](#1461)) ([9e7e572](9e7e572))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P0 An issue impacting production environments or impacting multiple releases or multiple individuals. released on @0.35.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants