Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Unit tests suite fails if ran without having a Kubernetes cluster running locally (kube config exists) #359

Closed
Tracked by #50
jeromy-cannon opened this issue Jun 6, 2024 · 3 comments · Fixed by #624
Closed
Tracked by #50

Bug: Unit tests suite fails if ran without having a Kubernetes cluster running locally (kube config exists) #359

jeromy-cannon opened this issue Jun 6, 2024 · 3 comments · Fixed by #624
Assignees
@instamenta
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P3 Low priority issue. Will not impact the release schedule if not complete. Testing Improvements Improvements that will result in better test coverage or more efficient testing

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Jun 6, 2024 •
edited
Loading

The Unit Tests that fail when running without a Kubernetes cluster when running locally should be updated to load a mock of K8 to avoid the failures generated when K8 finds a kube context.
@jeromy-cannon jeromy-cannon mentioned this issue Jun 6, 2024
Open
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Jun 6, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 📋 Backlog in Solo Jun 6, 2024
@jeromy-cannon jeromy-cannon added P3 Low priority issue. Will not impact the release schedule if not complete. Improvement Code changes driven by non business requirements labels Jun 6, 2024
@jeromy-cannon jeromy-cannon mentioned this issue Jun 6, 2024
Closed
6 tasks
@jeromy-cannon jeromy-cannon added Testing Improvements Improvements that will result in better test coverage or more efficient testing and removed Improvement Code changes driven by non business requirements labels Aug 22, 2024
@jeromy-cannon jeromy-cannon moved this from 📋 Backlog to 🔖 Ready in Solo Sep 19, 2024
@jeromy-cannon jeromy-cannon changed the title Unit tests suite fails if ran without having a Kubernetes cluster running Bug: Unit tests suite fails if ran without having a Kubernetes cluster running locally (kube config exists) Sep 19, 2024
@jeromy-cannon jeromy-cannon added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Sep 19, 2024
@instamenta
Copy link
Contributor

I personally don't have any problem with running the tests, even without running docker

@jeromy-cannon
Copy link
Contributor Author

Must be the way my machine is setup. renaming the ~/.kube/config seemed to make the problem go away as we saw on the call the other day.

@jeromy-cannon
Copy link
Contributor Author

jeromy-cannon commented Sep 20, 2024 •
edited
Loading

If you can't reproduce it, then maybe I can work it later, or if @JeffreyDallas can reproduce it on his machine he can take it.

@instamenta instamenta linked a pull request Sep 24, 2024 that will close this issue
fix(tests): start Kind cluster on demand if not having a kube config errors #624
Merged
@instamenta instamenta mentioned this issue Sep 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@instamenta instamenta

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs P3 Low priority issue. Will not impact the release schedule if not complete. Testing Improvements Improvements that will result in better test coverage or more efficient testing
Projects
Solo
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tests): start Kind cluster on demand if not having a kube config errors hashgraph/solo
2 participants
@jeromy-cannon @instamenta