Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support SOLO_HOME environment variable for home directory #53

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

leninmehedy
Copy link
Member

Description

This pull request changes the following:

  • allow user to specify solo home directory using environment variable.

Related Issues

@leninmehedy leninmehedy requested a review from a team as a code owner February 21, 2024 22:47
Copy link
Contributor

Unit Test Results

 1 files  ±0  13 suites  ±0   18s ⏱️ -6s
83 tests ±0  83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 41cdfa3. ± Comparison against base commit 6d3a89b.

Copy link
Contributor

E2E Test Results

732 tests  ±0   732 ✅ ±0   12m 6s ⏱️ - 1m 31s
  5 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 41cdfa3. ± Comparison against base commit 6d3a89b.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@6d3a89b). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   51.85%           
=======================================
  Files           ?       27           
  Lines           ?     2509           
  Branches        ?      368           
=======================================
  Hits            ?     1301           
  Misses          ?     1208           
  Partials        ?        0           
Files Coverage Δ
src/core/constants.mjs 92.06% <100.00%> (ø)

Impacted file tree graph

@leninmehedy leninmehedy merged commit 8745706 into main Feb 22, 2024
15 checks passed
@leninmehedy leninmehedy deleted the 0040-support-home-directory-env-variable branch February 22, 2024 19:56
swirlds-automation added a commit that referenced this pull request Feb 23, 2024
## [0.21.1](v0.21.0...v0.21.1) (2024-02-23)

### Bug Fixes

* support SOLO_HOME environment variable for home directory ([#53](#53)) ([8745706](8745706))
* update the address book and perform helm upgrade to fix mirror node importer ([#52](#52)) ([26e2e8f](26e2e8f))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.21.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon pushed a commit that referenced this pull request Feb 23, 2024
jeromy-cannon pushed a commit that referenced this pull request Feb 23, 2024
## [0.21.1](v0.21.0...v0.21.1) (2024-02-23)

### Bug Fixes

* support SOLO_HOME environment variable for home directory ([#53](#53)) ([8745706](8745706))
* update the address book and perform helm upgrade to fix mirror node importer ([#52](#52)) ([26e2e8f](26e2e8f))

Signed-off-by: Jeromy Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give the user the ability to override the SOLO_HOME_DIR location
3 participants