fix: Direct calling of node stop and start commands #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Ivo-Yankov
added
the
Bug
1 similar comment
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 37 37
Lines 5012 5012
Branches 767 691 -76
=======================================
Hits 4023 4023
Misses 988 988
Partials 1 1
|
jeromy-cannon
approved these changes
Oct 2, 2024
swirlds-automation
added a commit
that referenced
this pull request
Oct 4, 2024
## [0.31.0](v0.30.1...v0.31.0) (2024-10-04) ### Features * Add '--mirror-node-version' flag to override default mirror node version ([#616](#616)) ([e4932c4](e4932c4)) * add quiet flag ([#621](#621)) ([b068c8f](b068c8f)) * convert hugo docs workflow calls to use Taskfile task ([#642](#642)) ([ae8d8bb](ae8d8bb)) * ensured user-provided values file takes precedence over solo-generated values ([#615](#615)) ([1b0ffc9](1b0ffc9)) * **logging:** Add the new custom process output class and inject it into the default list renderer options ([#622](#622)) ([efa1783](efa1783)) * separate commands for solo node delete ([#597](#597)) ([b251276](b251276)) * Separate network upgrade and freeze from node update/add/delete command ([#628](#628)) ([9b17937](9b17937)) ### Bug Fixes * Direct calling of node stop and start commands ([#636](#636)) ([7749b04](7749b04)) * **docs:** resolve issues due to npx in taskfile for the custom-network-config example ([038e6df](038e6df)) * jsdoc failed but ci job not failed ([#608](#608)) ([3f838f6](3f838f6)) * specify jvm env variables explicitly for local profile ([#405](#405)) ([3db7e08](3db7e08)) * **tests:** start Kind cluster on demand if not having a kube config errors ([#624](#624)) ([538e40d](538e40d)) * upgrade eslint config away from abandoned plugin ([#643](#643)) ([84d3dc5](84d3dc5))
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the way flags are being passed in the declaration of the
solo node startandsolo node stopcommands.Related Issues