Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer #82

Merged
merged 2 commits into from
Feb 26, 2024
Merged

fix: updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer #82

merged 2 commits into from
Feb 26, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Feb 26, 2024 •
edited
Loading

Description

This pull request changes the following:

  • updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer
  • revert readme --fst-chart-version updates

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Feb 26, 2024
@jeromy-cannon jeromy-cannon changed the title fix: updated to allow connection to remote cluster that doesn't have … fix: updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer Feb 26, 2024
@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 26, 2024 21:30
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners February 26, 2024 21:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited
Loading

Unit Test Results

 1 files  ±0  13 suites  ±0   35s ⏱️ +4s
83 tests ±0  83 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7d08465. ± Comparison against base commit 402a22f.

♻️ This comment has been updated with latest results.

nathanklick
nathanklick previously approved these changes Feb 26, 2024
View reviewed changes
@jeromy-cannon jeromy-cannon force-pushed the 00081-solo-remote-cluster branch from 7399b36 to 7d08465 Compare February 26, 2024 21:47
@jeromy-cannon jeromy-cannon requested a review from a team as a code owner February 26, 2024 21:47
@github-actions GitHub Actions
Copy link
Contributor

E2E Test Results

  1 files  ±  0    5 suites  ±0   15m 48s ⏱️ + 11m 43s
732 tests ±  0  732 ✅ +  3  0 💤 ±0  0 ❌  - 3 
732 runs  +711  732 ✅ +714  0 💤 ±0  0 ❌  - 3 

Results for commit 7d08465. ± Comparison against base commit 402a22f.

This pull request removes 700 and adds 700 tests. Note that renamed tests count towards both. 
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 10 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 10 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 100 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 100 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 11 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 11 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 12 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 12 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 13 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 13 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 14 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 14 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 15 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 15 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 16 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 16 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 17 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] [beforeAll - ERROR]: only genesis account should have genesis key for all special accounts special account 17 should not have genesis key
…

NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 10 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 10 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 100 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 100 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 1000 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 11 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 11 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 12 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 12 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 13 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 13 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 14 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 14 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 15 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 15 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 16 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 16 should not have genesis key
NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 17 should not have genesis key ‑ NodeCommand node start should succeed [release v0.42.5, keyFormat: pfx] only genesis account should have genesis key for all special accounts special account 17 should not have genesis key
…

@jeromy-cannon jeromy-cannon merged commit 6df8928 into main Feb 26, 2024
13 of 14 checks passed
@jeromy-cannon jeromy-cannon deleted the 00081-solo-remote-cluster branch February 26, 2024 22:20
swirlds-automation added a commit that referenced this pull request Feb 27, 2024
@swirlds-automation
chore(release): 0.21.2 [skip ci]
e42f7a7 
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.21.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon added a commit that referenced this pull request Feb 27, 2024
@jeromy-cannon
fix: updated to allow node client to connect to remote cluster that d…
52082fd 
…oesn't have a LoadBalancer (#82)

Signed-off-by: Jeromy Cannon <[email protected]>
jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
@swirlds-automation @jeromy-cannon
chore(release): 0.21.2 [skip ci]
3e9b05b 
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))
jeromy-cannon added a commit that referenced this pull request Feb 27, 2024
@jeromy-cannon
fix: updated to allow node client to connect to remote cluster that d…
5cecbae 
…oesn't have a LoadBalancer (#82)

Signed-off-by: Jeromy Cannon <[email protected]>
jeromy-cannon pushed a commit that referenced this pull request Feb 27, 2024
@swirlds-automation @jeromy-cannon
chore(release): 0.21.2 [skip ci]
e346974 
## [0.21.2](v0.21.1...v0.21.2) (2024-02-27)

### Bug Fixes

* do not use solo version for fst-chart-version by default ([#67](#67)) ([2e19906](2e19906))
* updated to allow node client to connect to remote cluster that doesn't have a LoadBalancer ([#82](#82)) ([6df8928](6df8928))

Signed-off-by: Jeromy Cannon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanklick nathanklick nathanklick approved these changes

@leninmehedy leninmehedy leninmehedy approved these changes

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas

Assignees

@jeromy-cannon jeromy-cannon

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solo fails to create node client when using a remote cluster without a LoadBalancer configured
4 participants
@jeromy-cannon @swirlds-automation @leninmehedy @nathanklick