feat(cli): allow user to set jvm options for Hedera nodes #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leninmehedy
changed the title
leninmehedy
changed the title
Unit Test Results 1 files ±0 13 suites ±0 23s ⏱️ ±0s Results for commit d7a6f84. ± Comparison against base commit fd0ee4b. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
E2E Test Results 1 files ± 0 6 suites ±0 15m 26s ⏱️ + 2m 39s Results for commit d7a6f84. ± Comparison against base commit fd0ee4b. This pull request removes 700 and adds 700 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 63.72% 63.73%
=======================================
Files 27 27
Lines 2553 2570 +17
Branches 419 422 +3
=======================================
+ Hits 1627 1638 +11
- Misses 926 932 +6
|
leninmehedy
changed the title
leninmehedy
force-pushed
the
00066-unable-to-run-solo-cluster-setup
branch
from
e817281 to
038693e
Compare
leninmehedy
force-pushed
the
00066-unable-to-run-solo-cluster-setup
branch
2 times, most recently
from
7081196 to
3af16ad
Compare
leninmehedy
force-pushed
the
enable-jvm-options
branch
3 times, most recently
from
7f20984 to
e663f90
Compare
leninmehedy
force-pushed
the
00066-unable-to-run-solo-cluster-setup
branch
from
3af16ad to
5e21f91
Compare
|
@leninmehedy , just a thought, but if we created a persistent volume mount, we could just download one time and reduce the traffic |
jeromy-cannon
previously approved these changes
Feb 27, 2024
leninmehedy
force-pushed
the
enable-jvm-options
branch
from
e663f90 to
4ce84b6
Compare
Yes, hold on that thought. Please create a ticket to create persistent-volume and add your notes. PVC should be a high priority (maybe P1) |
Base automatically changed from
00066-unable-to-run-solo-cluster-setup
to
main
February 27, 2024 09:53
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
This is because fetching the platform zip file locally and then uploading to the container is time consuming and brittle. Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
enable-jvm-options
branch
from
4ce84b6 to
d7a6f84
Compare
nathanklick
approved these changes
Feb 28, 2024
1 task
swirlds-automation
added a commit
that referenced
this pull request
Mar 8, 2024
## [0.22.0](v0.21.2...v0.22.0) (2024-03-08) ### Features * **cli:** allow user to set jvm options for Hedera nodes ([#84](#84)) ([22ff35d](22ff35d)) * download helm binary based on os and platform architecture ([#128](#128)) ([e64e9a2](e64e9a2)) ### Bug Fixes * do checksum check after downloading platform zip file ([#125](#125)) ([3d91617](3d91617)) * updated incorrect log messages ([#132](#132)) ([d890974](d890974)) ### Performance Improvements * enhance account key update logic to batch transactions instead of loading all with sleep ([#105](#105)) ([e4bd1ef](e4bd1ef))
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
When node starts, JVM options are loaded from
/opt/hgcapp/services-Hedera/HapiApp2.0/application.envNow user is able to set JVM options with flag
--application-envflag.node start --application-env application.envRelated Issues