This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
ci: bump Go version to 1.18 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding until after we release today |
|
e2e tests are currently failing due to this change in Go 1.18
Fix should just be configuring TLS min version explicitly in the test client dialer. |
…where needed Go 1.18 disabled TLS 1.0 and 1.1 by default for client connections https://tip.golang.org/doc/go1.18#tls10
mikemorris
force-pushed
the
go-version/1.18
branch
from
368e798 to
e85715f
Compare
nathancoleman
approved these changes
Apr 28, 2022
nickethier
added a commit
that referenced
this pull request
Apr 29, 2022
This reverts commit 8cd8b37.
|
For future reference, apparently this missed bumping the actual version used for binary builds, see #189 |
mikemorris
added a commit
that referenced
this pull request
May 2, 2022
mikemorris
added a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
GO_VERSIONfor CI to 1.18reflect2dependency to avoid a segfaultHow I've tested this PR:
Running
go test ./...ininternal/k8s/builderpreviously failed with a segfault when running with Go 1.18 locally due to unsafe code used by thereflect2package (an indirect dependency from Kubernetes core). With this change tests now pass locally, and should be able to pass in CI as well.How I expect reviewers to test this PR:
Confirm that bumping the version in
go.modis not necessary as we aren't actually using any features like generic that require Go 1.18 yet, just fixing compatibility.Did I miss anywhere this needs to be bumped, e.g. for release pipelines?
CHANGELOG entry added