Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Multiple Pod IPs #201

Merged
merged 5 commits into from
May 31, 2022
Merged

Multiple Pod IPs #201

merged 5 commits into from
May 31, 2022
+83 −70

Conversation

sarahalsmiller
Copy link
Member

Changes proposed in this PR:

  • Assign multiple ips to gateways when there are multiple pods

How I've tested this PR:

  • Unit tests passing
  • attempting to replicate circumstances on a kind cluster

How I expect reviewers to test this PR:

  • Unit tests passing

Checklist:

  • [ X ] Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@sarahalsmiller sarahalsmiller added the pr/no-changelog Skip the CI check that requires a changelog entry label May 27, 2022
@sarahalsmiller sarahalsmiller changed the title Sa multiple pod ips Multiple Pod IPs May 27, 2022
nathancoleman
nathancoleman reviewed May 27, 2022
View reviewed changes
@sarahalsmiller sarahalsmiller marked this pull request as ready for review May 27, 2022 21:20
mikemorris
mikemorris approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@mikemorris mikemorris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just some additional minor pod -> pods renaming) - it appears the existing internal/k8s/reconciler/gateway_test.go tests are fully exercising that the expected host or pod IPs are being set on the gateway.

Probably worth adding a changelog entry?

@sarahalsmiller sarahalsmiller removed the pr/no-changelog Skip the CI check that requires a changelog entry label May 31, 2022
nathancoleman
nathancoleman reviewed May 31, 2022
View reviewed changes
@sarahalsmiller @nathancoleman
Update .changelog/201.txt
3ae6bc5 
Co-authored-by: Nathan Coleman <[email protected]>
@sarahalsmiller sarahalsmiller merged commit 9331dc0 into main May 31, 2022
@sarahalsmiller sarahalsmiller deleted the sa-multiple-pod-ips branch May 31, 2022 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikemorris mikemorris mikemorris approved these changes

@nathancoleman nathancoleman nathancoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahalsmiller @mikemorris @nathancoleman