Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Prefix URL Rewrite #282

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Prefix URL Rewrite #282

merged 3 commits into from
Jul 13, 2022

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented Jul 13, 2022

Changes proposed in this PR:

  • Implement support for URLRewrite type filter.

How I've tested this PR:

  • Spun up test cluster and configured routes with the URLRewrite filter set
        urlRewrite:
          path:
            type: "ReplacePrefixMatch"
            replacePrefixMatch: "/test"
  • Added tests

How I expect reviewers to test this PR:

  • Tests passing

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the various kinds of URL rewrites to dev/docs/supported-features.md and check off the one supported in this PR

@sarahalsmiller sarahalsmiller changed the title WIP- Sa url prefix rewrite Prefix URL Rewrite Jul 13, 2022
@sarahalsmiller sarahalsmiller marked this pull request as ready for review July 13, 2022 18:12
@nathancoleman nathancoleman mentioned this pull request Jul 13, 2022
@nathancoleman nathancoleman linked an issue Jul 13, 2022 that may be closed by this pull request
@sarahalsmiller sarahalsmiller force-pushed the sa-url-prefix-rewrite branch from b66fed7 to 88d200a Compare July 13, 2022 19:36
@sarahalsmiller sarahalsmiller merged commit d95679f into main Jul 13, 2022
@sarahalsmiller sarahalsmiller deleted the sa-url-prefix-rewrite branch July 13, 2022 20:29
@manobi
Copy link

manobi commented Jul 27, 2022

@sarahalsmiller I would love to test it, in which release is it going to be available?

@Jeff-Apple
Copy link
Contributor

@manobi

This feature will be in version 0.4, which we plan to release next month (August).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLRewrite support
4 participants