This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
Support routing to Consul services imported from a peer #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
the
pr/no-changelog
nathancoleman
commented
Oct 11, 2022
nathancoleman
force-pushed
the
peering
branch
3 times, most recently
from
26628e2 to
9951811
Compare
nathancoleman
removed
the
pr/no-changelog
nathancoleman
force-pushed
the
peering
branch
from
3da3501 to
510d45e
Compare
nathancoleman
requested review from
mikemorris,
andrewstucki and
sarahalsmiller
nathancoleman
force-pushed
the
peering
branch
from
54357d5 to
a9d18b6
Compare
nathancoleman
force-pushed
the
peering
branch
2 times, most recently
from
1b93176 to
9d53165
Compare
nathancoleman
commented
Nov 21, 2022
| @@ -1,14 +1,18 @@ | |||
| package testing | |||
| package consul | |||
There was a problem hiding this comment.
Had to move this file from testing to avoid circular imports
nathancoleman
added
the
pr/conformance
|
Confirmed this works with consul 1.14 and consul-k8s 1.0.0 |
2 tasks
andrewstucki
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Stub func for finding service imported from peer * Add peerName to MeshService CRD, fork service lookup when specified * Use "Peer" instead of "PeerName" for consistency * Add changelog entry * Return Consul resolution error when no matching service name from peer * Add unit test coverage for resolving of imported service from peer * Remove unnecessary mock generation target * go mod tidy * Consume latest tag of consul/api containing dependencies * Resolve dependency issues from merge * Add Peerings to Consul client interface * Adjust testing strategy to account for hot swap of Consul client
andrewstucki
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Stub func for finding service imported from peer * Add peerName to MeshService CRD, fork service lookup when specified * Use "Peer" instead of "PeerName" for consistency * Add changelog entry * Return Consul resolution error when no matching service name from peer * Add unit test coverage for resolving of imported service from peer * Remove unnecessary mock generation target * go mod tidy * Consume latest tag of consul/api containing dependencies * Resolve dependency issues from merge * Add Peerings to Consul client interface * Adjust testing strategy to account for hot swap of Consul client
andrewstucki
pushed a commit
that referenced
this pull request
Nov 22, 2022
…nto release/0.5.x (#465) * Support routing to Consul services imported from a peer (#406) * Stub func for finding service imported from peer * Add peerName to MeshService CRD, fork service lookup when specified * Use "Peer" instead of "PeerName" for consistency * Add changelog entry * Return Consul resolution error when no matching service name from peer * Add unit test coverage for resolving of imported service from peer * Remove unnecessary mock generation target * go mod tidy * Consume latest tag of consul/api containing dependencies * Resolve dependency issues from merge * Add Peerings to Consul client interface * Adjust testing strategy to account for hot swap of Consul client * Update changelog Co-authored-by: Nathan Coleman <[email protected]> Co-authored-by: Andrew Stucki <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
peerto theMeshServiceCRD enabling users to target a Consul service imported from a peering connectionpeerHow I've tested this PR:
GatewayandHTTPRoutewith aMeshServicebackend referencing one of the services imported from the other datacenterGatewayHow I expect reviewers to test this PR:
See above
Checklist: