This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
update to Go v1.19 #424
Merged
update to Go v1.19 #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
added
the
pr/conformance
|
@mikemorris can you update the pin in |
I was under the impression that should only updated when actually necessary (e.g. introducing usage of a new feature like generics) but I suppose it could be easy to miss that instance if we're only developing/building/testing on Go 1.19 😐 Thoughts? |
|
that makes sense |
nathancoleman
approved these changes
Oct 24, 2022
|
@mdeggies @samsalisbury could one of you please review when you get a moment on behalf of RelEng? |
nathancoleman
force-pushed
the
go/1.19
branch
from
0a270b1 to
ee2631a
Compare
modrake
approved these changes
Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
internal/tools.gofollowing existing pattern, to allow versioning throughgo.modHow I've tested this PR:
Running all CI tests including conformance.
How I expect reviewers to test this PR:
Verify that updates seem reasonable.
Checklist: