ui: Adds ability to show a 'partial' list in list-collections #10174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
ui/feature/partial-list-collection
branch
from
67443f6 to
05ba731
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/366012. |
|
🍒✅ Cherry pick of commit 0e4db3f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 7, 2021
* ui: Add support for showing partial lists in ListCollection * Add CSS for partial 'View more' button, and move all CSS to /components * Enable partial view for intention permissions
|
🍒✅ Cherry pick of commit 0e4db3f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 7, 2021
* ui: Add support for showing partial lists in ListCollection * Add CSS for partial 'View more' button, and move all CSS to /components * Enable partial view for intention permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a component that we use quite a lot called
<ListCollection />, we use it for our 'virtual/DOM-recycling scrolling' and just for normal 'native scrolling' lists.This PR adds a
@partialattribute to this component, letting you specify that you only want a certain number of rows to show initially. When this attribute is set, we also render a 'View more' button to let the user expand the list to show all the rows instead of just a 'partial' amount.We also took the opportunity here to move the
list-collectionstyles into theapp/components/list-collectionfolder, so everything is co-located in the one folder.