Service Discovery ACLs #1024
Merged
Service Discovery ACLs #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,7 +126,7 @@ func (c *Catalog) ListNodes(args *structs.DCSpecificRequest, reply *structs.Inde | |||
| state.QueryTables("Nodes"), | |||
| func() error { | |||
| reply.Index, reply.Nodes = state.Nodes() | |||
| return nil | |||
| return c.srv.filterACL(args.Token, reply) | |||
There was a problem hiding this comment.
Oh probably not, haha good catch.
|
Minor comments, but LGTM! 💪 👍 |
|
|
||
| case *structs.IndexedNodeDump: | ||
| filt.filterNodeDump(&v.Dump) | ||
| } |
There was a problem hiding this comment.
This seems like the kind of thing that should freak out if a new type is encountered (we could add case clauses for ones that we explicitly don't care to filter).
There was a problem hiding this comment.
Seems reasonable, will add that in!
ryanuber
force-pushed
the
f-discovery-acl
branch
from
0c5191c to
389f892
Compare
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
… is offline (hashicorp#1024) * Fail scheduling all pods that are not part of consul when the webhook is unhealthy. Co-authored-by: Iryna Shustava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a filter on top of the state store to allow restricting read access to services. This allows issuing tokens which can only see services they have explicit permissions to read. The documentation is purposely left kind of half-complete so that we can polish it off after the DNS side of this is more complete, but we can tackle that in a separate PR.