Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: ensure single L7 deny intention with default deny policy does not result in allow action (CVE-2021-36213) #10619

Merged
merged 1 commit into from
Jul 15, 2021
Merged

xds: ensure single L7 deny intention with default deny policy does not result in allow action (CVE-2021-36213) #10619

merged 1 commit into from
Jul 15, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jul 15, 2021 •
edited
Loading

Note to self:

@rboyer rboyer requested a review from a team July 15, 2021 14:28
@rboyer rboyer self-assigned this Jul 15, 2021
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Jul 15, 2021
@rboyer rboyer force-pushed the fix-intention-enforcement branch from 9fe8cc5 to 06e36f2 Compare July 15, 2021 14:30
@vercel vercel bot temporarily deployed to Preview – consul July 15, 2021 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 15, 2021 14:30 Inactive
rboyer added a commit that referenced this pull request Jul 15, 2021
@rboyer
(1.9.x) xds: ensure single L7 deny intention with default deny policy…
d22e656 
… does not result in allow action (CVE-2021-36213)

Backport of #10619 to 1.9.x
@rboyer rboyer mentioned this pull request Jul 15, 2021
Merged
dhiaayachi
dhiaayachi approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much that part of the code but I trust that this has been already reviewed

@rboyer rboyer merged commit 20feb42 into main Jul 15, 2021
@rboyer rboyer deleted the fix-intention-enforcement branch July 15, 2021 15:09
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/410385.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 20feb42 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jul 15, 2021
@rboyer @hc-github-team-consul-core
xds: ensure single L7 deny intention with default deny policy does no…
104ee65 
…t result in allow action (CVE-2021-36213) (#10619)
rboyer added a commit that referenced this pull request Jul 15, 2021
@rboyer
(1.9.x) xds: ensure single L7 deny intention with default deny policy…
3ca2442 
… does not result in allow action (CVE-2021-36213) (#10620)

Backport of #10619 to 1.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Assignees

@rboyer rboyer

Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rboyer @hc-github-team-consul-core @dhiaayachi